Drop support for embedding type1 entries directly in an image #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not going to use this in bootc and right now we just error if we encounter it, and I am not aware of a good use case. Signed-off-by: Colin Walters <[email protected]>
|
OK yeah, I guess some of the cross-distro stuff is using the type1 support today and that would need to be ported to be UKIs. |
|
I think it's better to merge |
|
Type1 entries involve loading the text-format config, no? I'd prefer to keep this... |
|
Most cases would be either bootc or compoesfs-boot create generating these config flies using the kernel + initrd right? Would we have a case where we'd want to use the configs provided by a user? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not going to use this in bootc and right now we just error if we encounter it, and I am not aware of a good use case.